Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Improve layout for small resolutions #102

Merged
merged 5 commits into from
Jun 28, 2016

Conversation

fabienrohrer
Copy link
Member

@fabienrohrer fabienrohrer commented Jun 28, 2016

  • Fix not highlighted code overflow: allow horizontal scroll when required
  • Fix texts of the menu overflow: crop it (horizontal scroll is not a good idea there, because scrolling vertically in the menu is recommended.).
  • Fix menu arrows overlap
  • Fix horizontal scroll bar of the menu shown for no reason
  • Test
    • Embedded in Webots
    • Firefox
    • Chrome
    • Safari
    • IE
    • Edge

@fabienrohrer fabienrohrer self-assigned this Jun 28, 2016
@fabienrohrer
Copy link
Member Author

The situation is much better now, but still not perfect: if the menu is too small, it becomes unreadable.

capture d ecran 2016-06-28 a 11 53 16
capture d ecran 2016-06-28 a 11 56 15
capture d ecran 2016-06-28 a 11 57 34
capture d ecran 2016-06-28 a 13 58 33

I propose to accept this PR as-is, and to explore the solution to put the menu into a resizable panel (as proposed by Stefania in #76) in another PR.

@fabienrohrer
Copy link
Member Author

👍

@stefaniapedrazzi
Copy link
Member

stefaniapedrazzi commented Jun 28, 2016

It seems that you removed the horizontal scrollbar of the left menu.
Wasn't possible to fix the issues without removing it?

Personally I would keep the horizontal scrollbar and additionally make the left menu resizable.

@stefaniapedrazzi
Copy link
Member

In any case all the other issues are fixed and I confirm that now it is already better.

@fabienrohrer
Copy link
Member Author

A better patch is indeed probably possible.
I would propose to accept this as-is if you agree in order to not waste too much time with this, because the solution to have a resizable menu will probably completely change this part of the code.

@stefaniapedrazzi
Copy link
Member

It is ok for me to accept this PR as-it-is if the resizable menu will be introduced before releasing Webots 8.5.0.
Otherwise we should at least reintroduce the horizontal scrollbar.

👍

@fabienrohrer
Copy link
Member Author

Ok, I'm working on this this afternoon.

@fabienrohrer fabienrohrer merged commit cbc8639 into master Jun 28, 2016
@fabienrohrer fabienrohrer deleted the fix-layout-for-small-resolutions branch June 28, 2016 12:44
@omichel omichel mentioned this pull request Jul 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants