Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming #12

Open
antonkomarev opened this issue Aug 15, 2022 · 2 comments
Open

Improve naming #12

antonkomarev opened this issue Aug 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@antonkomarev
Copy link
Member

antonkomarev commented Aug 15, 2022

Make naming consistent.

Game — is a planning poker game. Game contains of game sessions. Each session belongs to a topic (issue/task).

Game session phases

  • discussion
  • estimation
  • resolution

Initiator operations

  • start_estimation
  • end_estimation
  • clear_votes
  • re_estimate

Callbacks

  • discussion-vote-click-{topic_message_id}-{vote}
  • estimation-vote-click-{topic_message_id}-{vote}
  • {operation}-click-{topic_message_id}
    • start_estimation-click-{topic_message_id}
    • end_estimation-click-{topic_message_id}
    • clear_votes-click-{topic_message_id}
    • re_estimate-click-{topic_message_id}

Class types

  • Game
  • GameSession
  • GameRegistry
  • DiscussionVote
  • EstimationVote
This was referenced Aug 16, 2022
@antonkomarev
Copy link
Member Author

All is done, just need to rework callbacks naming

@antonkomarev
Copy link
Member Author

antonkomarev commented Aug 18, 2022

click-{topic_message_id}-discussion-vote-{vote}
click-{topic_message_id}-estimation-vote-{vote}
click-{topic_message_id}-operation-{operation}
    click-{topic_message_id}-operation-start-estimation
    click-{topic_message_id}-operation-end-estimation
    click-{topic_message_id}-operation-clear-votes
    click-{topic_message_id}-operation-re-estimate

@antonkomarev antonkomarev added the enhancement New feature or request label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant