Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cybersearch.toml #184

Merged
merged 2 commits into from Feb 2, 2019
Merged

Update cybersearch.toml #184

merged 2 commits into from Feb 2, 2019

Conversation

dimakorzhovnik
Copy link
Member

@dimakorzhovnik dimakorzhovnik commented Feb 2, 2019

Pull request template

Thank you for your contribution. We hope that your work is useful. To avoid extra questions from our side please describe your PR and done checklist.

Get in touch

Before starting to work on a feature or a fix, please open an issue to discuss the use case or bug with us. This can save a lot of time for both you and us. For any non-trivial change, we ask you to create a short design document explaining:

  • Why is this change done? What's the use case?
  • What will the API looks like? (For new features)
  • What test cases should it have? What could go wrong?
  • How will it roughly be implemented? (We'll happily provide code pointers to save your time)

Link it

Reference your issue to PR

Checklist

Put an x in the boxes that are applied. You can also fill them out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have opened an issue
  • I have read the CONTRIBUTING doc
  • I keep pull requests small so they can be easily reviewed
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove that my fix is effective or my feature works
  • I have added necessary documentation (if appropriate)
  • I have ensured there were no compiler warnings
  • I avoid breaking the continuous integration build
  • I avoid making significant changes to the driver's overall architecture.
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Getting help

If you run into any trouble, please reach out to us on the issue you are working on.

Our thanks

We deeply appreciate your effort toward improving Search. For any contribution, large or small, you will be immortalized in the release notes for the version you've contributed to.

@asadovka asadovka merged commit 4f63f20 into master Feb 2, 2019
@asadovka asadovka deleted the dimakorzhovnik-patch-1 branch February 2, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants