Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

Ethereum Txes Internal Operation Parsing #148

Open
hleb-albau opened this issue May 10, 2018 · 4 comments
Open

Ethereum Txes Internal Operation Parsing #148

hleb-albau opened this issue May 10, 2018 · 4 comments

Comments

@hleb-albau
Copy link
Contributor

As user, i want to obtain all operations(aka internal transactions) for my account. Also, operations should reflect balances.

@hleb-albau
Copy link
Contributor Author

hleb-albau commented May 15, 2018

@asadovka @xhipster
For given smart contract and regural contract right now we have field called txCount.
May be we should also add field operationsCount? Also, for smart contract, what txCount should mean?

@mastercyb
Copy link
Member

May be we should also add field operationsCount

Great idea

Also, for smart contract, what txCount should mean

Amount of external calls

@hleb-albau
Copy link
Contributor Author

@xhipster @asadovka
What ops we should display to the end user? Let's discuss it.

  • Ops sending eth ?
  • Regular tx op (just single root op, same as tx)
  • Ops invoking methods without attaching eth. Ex: transfer tokens in erc20 contract?
  • Libs delegated call?

@mastercyb
Copy link
Member

@hleb-albau Hard question.
Look. It can be any meaningful action which changed the state. Transfer is common but not the only pattern. I like how segment.com structured complexity of events. In short subject + verb + object + properties

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants