Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if path is exists #321

Merged
merged 1 commit into from
Mar 4, 2014
Merged

check if path is exists #321

merged 1 commit into from
Mar 4, 2014

Conversation

raianul
Copy link
Contributor

@raianul raianul commented Mar 4, 2014

No description provided.

@raianul raianul mentioned this pull request Mar 4, 2014
Closed
@cyberdelia
Copy link
Member

Good catch. Thanks!

cyberdelia added a commit that referenced this pull request Mar 4, 2014
@cyberdelia
Merge pull request #321 from newscred/fix-path-error
c03911b 
check if path is exists
@cyberdelia cyberdelia merged commit c03911b into jazzband:master Mar 4, 2014
@raianul
Copy link
Contributor Author

raianul commented Mar 5, 2014

@cyberdelia I have done a mistake, if you please revert that commit and add this one it will solved.
#322

path should be checked at first. cause if the last index is getting None, then it will execute original_file = self.open(path), which will through error

@raianul raianul mentioned this pull request Mar 5, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raianul @cyberdelia