ignore reclose db error by pymysql.err.Error #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when it used on flask with socketio, will be trigger teardown_request event as muilt times by the client long-polling, there were some trace log:
Traceback (most recent call last):
File "D:\Tools\Python363\lib\site-packages\eventlet\wsgi.py", line 539, in handle_one_response
result = self.application(self.environ, start_response)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1997, in __call__
return self.wsgi_app(environ, start_response)
File "D:\Tools\Python363\lib\site-packages\engineio\middleware.py", line 49, in __call__
return self.wsgi_app(environ, start_response)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1993, in wsgi_app
ctx.auto_pop(error)
File "D:\Tools\Python363\lib\site-packages\flask\ctx.py", line 387, in auto_pop
self.pop(exc)
File "D:\Tools\Python363\lib\site-packages\flask\ctx.py", line 353, in pop
self.app.do_teardown_request(exc)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1879, in do_teardown_request
func(exc)
File "D:\Tools\Python363\lib\site-packages\flaskext\mysql.py", line 59, in teardown_request
ctx.mysql_db.close()
File "D:\Tools\Python363\lib\site-packages\pymysql\connections.py", line 728, in close
raise err.Error("Already closed")
pymysql.err.Error: Already closed
|
line 60 is wrong |
|
runing on python2? |
|
you wrote wrong at line 60 in the code you have committed, it is except Exception instead of catch Exception. catch Exception is not used in python2 or python3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when it used on flask with socketio, will be trigger teardown_request event as muilt times by the client long-polling, there were some trace log:
Traceback (most recent call last):
File "D:\Tools\Python363\lib\site-packages\eventlet\wsgi.py", line 539, in handle_one_response
result = self.application(self.environ, start_response)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1997, in call
return self.wsgi_app(environ, start_response)
File "D:\Tools\Python363\lib\site-packages\engineio\middleware.py", line 49, in call
return self.wsgi_app(environ, start_response)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1993, in wsgi_app
ctx.auto_pop(error)
File "D:\Tools\Python363\lib\site-packages\flask\ctx.py", line 387, in auto_pop
self.pop(exc)
File "D:\Tools\Python363\lib\site-packages\flask\ctx.py", line 353, in pop
self.app.do_teardown_request(exc)
File "D:\Tools\Python363\lib\site-packages\flask\app.py", line 1879, in do_teardown_request
func(exc)
File "D:\Tools\Python363\lib\site-packages\flaskext\mysql.py", line 59, in teardown_request
ctx.mysql_db.close()
File "D:\Tools\Python363\lib\site-packages\pymysql\connections.py", line 728, in close
raise err.Error("Already closed")
pymysql.err.Error: Already closed