-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized backoff functionality #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, John. Let's get this tested and try to merge it soon.
@@ -148,6 +148,32 @@ var Helper = { | |||
consoleEnd: "\x1b[0m", | |||
|
|||
consoleGreen: "\x1b[32m", | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is really clean and well-written, great work!
src/Supervisor.ts
Outdated
@@ -7,6 +7,9 @@ import connectionPool from "./connectors/ConnectionPool"; | |||
import * as events from "events"; | |||
import DB from "./DB"; | |||
import NodeSSH = require("node-ssh"); | |||
import BaseConnector from "./connectors/BaseConnector"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the BaseConnector and Console imports still necessary or left-over from the previous implementation? If not, let's remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Supervisor.ts
using generalized backoff