Adding Allocation and Partition - New Approach #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JTSIV1
commented
Apr 26, 2024
JTSIV1
commented
- allocation and partition are now specified in slurm parameters in the job and sent to the HPC
- defaults are in a new place in the hpc configs
- defaults are followed if nothing else specified
JTSIV1
changed the title
|
@JTSIV1 could you resolve these conflicts? |
alexandermichels
requested changes
May 13, 2024
| @@ -79,6 +88,7 @@ ${ | |||
| } | |||
| ${config.gpus_per_task ? `#SBATCH --gpus-per-task=${config.gpus_per_task}` : ""} | |||
| ${config.partition ? `#SBATCH --partition=${config.partition}` : ""} | |||
| ${config.allocation ? `#SBATCH -A << ${config.allocation} >>` : ""} | |||
There was a problem hiding this comment.
This doesn't work. You need to remove the << and >> around the allocation. The output should look like:
#SBATCH -A xxxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.