Potential Alternative to Echo for File Transfer #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
echo ${content} >> ${file)has caused a few problems in the Core when trying to write bash functions or environmental variables (see #69). This PR seeks to replace that by instead creating a temporary local file, transferring it, and then deleting the local file.Overview of Changes:
transferFilefunction which performs the file transfer part of theuploadfunction without the zip/unzip.uploadnow callstransferFile.createFileto create a local temp file with a random unique name, transfer the file usingtransferFile, and delete the local copy.