Error on startup when account has devices without alarm support #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I have been trying to setup this integration for quite some time, now I finally got the time to look at it and I managed to find out what was the issue.
After applying my credentials and when the integration tries to startup but then I got this error (then it loops until Garmin blocks all requests)
So I debugged the source code locally and it seems that, I have a device (Garmin Vector 3 pedals) that returns
alarms: null
inside thedevice_settings
, making the current code crash and the whole startup process fails. Simply adding this null check fixes this by simply ignoring that device.Please have a look when you have time, and let me now if I need to update something