Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datetimes can be localized (interface pages) #49

Closed
wants to merge 1 commit into from

Conversation

yfdyh000
Copy link
Contributor

This allows translators to correct illegal datetime formats, for example: #47 (comment).

  1. This changes is not tested, I don't have a PHP runtime.
  2. %k:%M looks like an unnecessary difference, I unify it.
  3. (UTC) can also be added internally, but this prevents more flexible internationalization. I'm not sure why there is this difference.
  4. This program does not appear to have HTML Safety (like this), which may be an issue for preventing malicious translation attacks.

@cyberpower678
Copy link
Owner

Sorry, but this is a messy solution. Also in v2.0 a new date time system is in place to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants