Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-dependency Docker Image #11

Open
thelicato opened this issue Jan 10, 2022 · 1 comment
Open

Multi-dependency Docker Image #11

thelicato opened this issue Jan 10, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thelicato
Copy link
Collaborator

Since there are multiple tools that can depend on other there may be the need to update the Docker Image also when one of the dependencies get updated. The solution is to add a new boolean parameter in the config.py called "build_always" that behaves in this way:

  • If "build_always" is True the image is built anyway (even if the version on Docker Hub is the same)
  • If the --push option is specified and there is already a version with the same tag nameon Docker Hub then the digest of the newly build image is checked against the digest of the image on Docker Hub. If they are different the new image is pushed on Docker Hub keeping the same tag version.

In this way it is possible to have a multi-dependency Docker Image.

@thelicato thelicato added enhancement New feature or request help wanted Extra attention is needed labels Jan 10, 2022
@thelicato
Copy link
Collaborator Author

The alternative is to use a different tag name (say daily) and keep the other tags untouched. The same behaviour of the digest applies the same way, but on a "special" tagname. What do you think is the best solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant