Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert util functions with dispatch to action-creators #669

Closed
raineorshine opened this issue May 18, 2020 · 1 comment · Fixed by #670
Closed

Convert util functions with dispatch to action-creators #669

raineorshine opened this issue May 18, 2020 · 1 comment · Fixed by #670
Assignees
@shresthabijay
Labels
duplicate Already exists refactor Refactor without changing behavior

Comments

@raineorshine
Copy link
Contributor

Convert util functions with dispatch to action-creators. Follow conventions of existing action-creators.

  • importText
  • loadLocalState
  • login
  • logout
  • updateUrlHistory
  • userAuthenticated

I think those are all of them. If you find any others let me know.
@raineorshine raineorshine added the refactor Refactor without changing behavior label May 18, 2020
@shresthabijay shresthabijay self-assigned this May 19, 2020
@shresthabijay shresthabijay mentioned this issue May 19, 2020
Merged
@raineorshine
Copy link
Contributor Author

Duplicate #511

@raineorshine raineorshine added the duplicate Already exists label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shresthabijay shresthabijay

Labels
duplicate Already exists refactor Refactor without changing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utils to Action Creators shresthabijay/em
2 participants
@raineorshine @shresthabijay