Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setting alert to null for valid gesture #671

Closed

Conversation

shresthabijay
Copy link
Collaborator

fixes #665

@shresthabijay
Copy link
Collaborator Author

@raineorshine The issue was specific to mobile because alert was set to null at handleGestureEnd without checking if the gesture was valid.

setTimeout(() => alert(null))

So whenever delete gesture was complete, archiveThought showed undo alert and immediately after that handleGestureEnd set it to null.

I made changes so that alert is set to null inside handleGestureEnd only if the gesture is not valid. Please review the changes. Thank you!

@raineorshine
Copy link
Contributor

That's definitely the cause, but unfortunately we need to clear the gesture hint when the gesture is valid.

In the process of investigating, I stumbled upon a solution. Will you review? #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Undo Archive Alert flashes
2 participants