Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deferred call to os.Exit(exitCode) may hide panics #569

Closed
pashagolub opened this issue May 23, 2023 · 0 comments · Fixed by #570
Closed

deferred call to os.Exit(exitCode) may hide panics #569

pashagolub opened this issue May 23, 2023 · 0 comments · Fixed by #570
Assignees
@pashagolub
Labels
🐞 bug Something isn't working ⚡ priority This issue if of high priority, but not critical

Comments

@pashagolub
Copy link
Collaborator

Should be

	defer func() {
		if err := recover(); err != nil {
			exitCode = ExitCodeFatalError
			log.GetLogger(ctx).WithField("callstack", string(debug.Stack())).Error(err)
		}
		os.Exit(exitCode)
	}()
@pashagolub pashagolub self-assigned this May 23, 2023
@pashagolub pashagolub added 🐞 bug Something isn't working ⚡ priority This issue if of high priority, but not critical labels May 23, 2023
@pashagolub pashagolub linked a pull request May 24, 2023 that will close this issue
[-] make sure panics output won't be hidden, fixes #569 #570
Merged
pashagolub added a commit that referenced this issue May 24, 2023
@pashagolub
Merge pull request #570 from cybertec-postgresql/569-unhide-panics
529506d 
[-] make sure panics output won't be hidden, fixes #569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pashagolub pashagolub

Labels
🐞 bug Something isn't working ⚡ priority This issue if of high priority, but not critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[-] make sure panics output won't be hidden, fixes #569 cybertec-postgresql/pg_timetable
1 participant
@pashagolub