Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] fix "invalid command 'BEGIN READ WRITE'" error when '--conn-pooling' option is on #586

Merged
merged 1 commit into from Mar 6, 2023

Conversation

IlyaTsoi
Copy link
Contributor

If the gatherer is running with the '--conn-pooling on' option fetching pgbouncer metrics fails with errors "invalid command 'BEGIN READ WRITE'. Use SHOW HELP". This changes remove 'sqlLockTimeout' from 'sqlToExec' for pgbouncer metrics and assign usage 'DBExecRead' method for pgbouncer metrics independently of '--conn-pooling' option value

If the gatherer is running with the '--conn-pooling on' option, then fetching pgbouncer metrics fails with errors "invalid command 'BEGIN READ WRITE'. Use SHOW HELP". This changes remove 'sqlLockTimeout' from 'sqlToExec' for pgbouncer metrics and assign usage 'DBExecRead' for pgbouncer metrics independently of '--conn-pooling' option value
@IlyaTsoi
Copy link
Contributor Author

This error is reproduced when fetching postgres metrics via pgbouncer (in this case using --conn-pooling option is recomend).

@pashagolub pashagolub changed the title fix "invalid command 'BEGIN READ WRITE'" error when '--conn-pooling' option is on [-] fix "invalid command 'BEGIN READ WRITE'" error when '--conn-pooling' option is on Feb 9, 2023
@pashagolub pashagolub self-assigned this Mar 6, 2023
@pashagolub
Copy link
Collaborator

Thanks for the help!

@pashagolub pashagolub merged commit 105e439 into cybertec-postgresql:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants