[-] fix timeline ID conversion in wal metric from hexadecimal to decimal
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashagolub
changed the title
wal metric from hexadecimal to decimal
pashagolub
approved these changes
Feb 17, 2023
|
Thanks a lot for your help! |
|
thank you ! |
pashagolub
added a commit
to cybertec-postgresql/pgwatch3
that referenced
this pull request
Feb 17, 2023
pashagolub
added a commit
to cybertec-postgresql/pgwatch3
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As timelineid is hexadecimal in pg_walfile_name(), this fix correctly convert it to int.
Without this fix, queries fail when tlid reaches to A, and could give wrong results when decimals symbols is used