Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] add lag in milliseconds to replication metrics #607

Merged
merged 1 commit into from Feb 21, 2023

Conversation

kmoppel-cognite
Copy link
Collaborator

In addition to lag bytes

@kmoppel-cognite
Copy link
Collaborator Author

I think milliseconds is enough precision. Technically Postgres has microseconds for time, but real world networking isn't really sub 1ms I think?

Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pashagolub pashagolub changed the title Metrics: replication - add lag in milliseconds [+] add lag in milliseconds to replication metrics Feb 21, 2023
@pashagolub pashagolub self-assigned this Feb 21, 2023
@pashagolub pashagolub merged commit cd8d201 into master Feb 21, 2023
@pashagolub pashagolub deleted the replication-metric-add-lag-in-milliseconds branch February 21, 2023 10:04
pashagolub added a commit to cybertec-postgresql/pgwatch3 that referenced this pull request Feb 21, 2023
pashagolub added a commit to cybertec-postgresql/pgwatch3 that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants