Stop if pipe has no data #27 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalaleev
requested changes
Jul 9, 2019
notifier.cpp
Outdated
| std::string subject; | ||
| std::string data; | ||
| std::string subject = ""; | ||
| std::string data = ""; |
There was a problem hiding this comment.
Default constructor of std::string already do it.
s-medvedev
requested changes
Jul 10, 2019
notifier.cpp
Outdated
| if (done) { | ||
| if (msg->data.size()) { | ||
| std::cerr << "WARNING! Pipe hasn't empty." << std::endl; | ||
| done = false; |
There was a problem hiding this comment.
This doesn't work because you clear done flag. User send SIGTERM signal, done-flag was set in interrupt handler. In this line it was clear. How way user can stop the notifier if msg has data?
afalaleev
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.