Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid delpermlink for posts in cashout window #928

Closed
afalaleev opened this issue Oct 18, 2019 · 2 comments
Closed

Forbid delpermlink for posts in cashout window #928

afalaleev opened this issue Oct 18, 2019 · 2 comments
Assignees
@soft-bagel-93
Labels
Medium
Milestone
Sprint-oct-14

Comments

@afalaleev
Copy link
Contributor

No description provided.

@gropox
Copy link

gropox commented Oct 18, 2019

есть же delete_message со всеми проверками, удалить delpermlink, а в delpermlinks вызвать delete_message

@afalaleev
Copy link
Contributor Author

They have different purposes:

  • deletemssg is used by the author to delete a post / comment.
  • delpermlink is used by the application to cure the BW of the application, so it can't be used for messages in cashout window

@soft-bagel-93 soft-bagel-93 self-assigned this Oct 27, 2019
@soft-bagel-93 soft-bagel-93 added this to the Sprint-oct-14 milestone Oct 27, 2019
soft-bagel-93 added a commit that referenced this issue Oct 28, 2019
@soft-bagel-93
Forbid delpermlink for messages in cashout windows #928
106dd18
@soft-bagel-93 soft-bagel-93 mentioned this issue Oct 28, 2019
Merged
soft-bagel-93 added a commit that referenced this issue Oct 28, 2019
@soft-bagel-93
Remove cyberway contracts tests from Buildkite scripts #928
65ac6c8
afalaleev added a commit that referenced this issue Oct 28, 2019
@afalaleev
Merge pull request #931 from cyberway/928-delpermlink-not-in-cashout
dc19ff2 
 Forbid delpermlink for messages in cashout windows #928 and speed up tests #932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soft-bagel-93 soft-bagel-93

Labels
Medium
Projects
None yet
Milestone
Sprint-oct-14
Development

No branches or pull requests
4 participants
@gropox @afalaleev @s-medvedev @soft-bagel-93