349 add referral to beneficiaries list when the post is published #389

adedkov · 2019-01-03T14:59:14Z

No description provided.

s-medvedev · 2019-01-10T09:38:40Z

golos.publication/golos.publication.cpp

    //reusing a vector
    beneficiaries.reserve(benefic_map.size());
    beneficiaries.clear();
-    for(auto & ben : benefic_map)
+    for(auto & ben : benefic_map) {


Please, remove unnecessary changes.

s-medvedev · 2019-01-10T10:11:51Z

golos.publication/golos.publication.cpp

@@ -124,14 +125,34 @@ void publication::create_message(name account, std::string permlink,
    }
    eosio_assert((benefic_map.size() <= max_beneficiaries_param.max_beneficiaries), "publication::create_message: benafic_map.size() > MAX_BENEFICIARIES");

+    auto obj_referral = golos::referral::account_referrer( config::referral_name, account );


These actions must be performed if the parameters of the posting contract specify the referral program contract (see #383). I still can’t merge those changes, but you can rebase your PR on them and use the added parameter of the referral program.

Please, use parameter with referral contracts account.

s-medvedev · 2019-01-10T10:14:57Z

tests/golos.publication_tests.cpp

    BOOST_CHECK_EQUAL(success(), post.create_msg(N(brucelee), "permlink"));

+    auto expire = 8; // sec
+    BOOST_CHECK_EQUAL(success(), referral.create_referral(N(dan.larimer), N(chucknorris), 500,


I am opposed to testing a bunch of posting a contract and a referral program contract in basic posting contract tests.
Please, make this test in referral contract tests (as for social contract, see https://github.com/GolosChain/golos-smart/blob/master/tests/golos.social_tests.cpp#L109-L143).

And remove all changes from base tests.

s-medvedev · 2019-01-10T10:17:57Z

tests/golos.publication_tests.cpp

    BOOST_TEST_MESSAGE("--- checking that another user can create a message with the same permlink.");
    BOOST_CHECK_EQUAL(success(), post.create_msg(N(chucknorris), "permlink"));

    auto id = hash64("permlink");
+    auto post_chucknorris = post.get_message(N(chucknorris), id);
+    auto size_ben = post_chucknorris["beneficiaries"].size();
+    BOOST_CHECK_EQUAL( post_chucknorris["beneficiaries"][size_ben - 1].as<structures::beneficiaries>().account, N(dan.larimer) );


This check is not enough. We need to check that he has the right percentage of reward. Still need to make a check for incorrect input.

s-medvedev · 2019-01-11T03:24:34Z

golos.publication/golos.publication.cpp

@@ -124,14 +125,34 @@ void publication::create_message(name account, std::string permlink,
    }
    eosio_assert((benefic_map.size() <= max_beneficiaries_param.max_beneficiaries), "publication::create_message: benafic_map.size() > MAX_BENEFICIARIES");

+    auto obj_referral = golos::referral::account_referrer( config::referral_name, account );


Please, use parameter with referral contracts account.

s-medvedev · 2019-01-11T03:27:07Z

tests/golos.referral_tests.cpp

+    BOOST_CHECK_EQUAL( post_sania["beneficiaries"][size_ben - 1].as<beneficiary>().account, N(issuer) );
+
+    BOOST_CHECK_EQUAL(success(), referral.create_referral(N(issuer), N(pasha), 5000, cur_time().to_seconds() + expire, asset(50000, _sym)));
+    BOOST_CHECK_EQUAL(err.limit_percents, post.create_msg(N(pasha), "permlink", N(), "parentprmlnk", { beneficiary{N(tania), 7000} }));


Test when referral already exist in beneficiary list?
Test when referral and beneficiary list execute success?

s-medvedev · 2019-01-11T03:28:01Z

tests/golos.referral_tests.cpp

+    auto id = hash64("permlink");
+    auto post_sania = post.get_message(N(sania), id);
+    auto size_ben = post_sania["beneficiaries"].size();
+    BOOST_CHECK_EQUAL( post_sania["beneficiaries"][size_ben - 1].as<beneficiary>().account, N(issuer) );


Check that size_ben equal 1?
And that percent equal from referral program?

s-medvedev · 2019-01-11T03:29:55Z

tests/golos.publication_tests.cpp

        produce_block();

        install_contract(_code, contracts::posting_wasm(), contracts::posting_abi());
        install_contract(cfg::vesting_name, contracts::vesting_wasm(), contracts::vesting_abi());
        install_contract(cfg::token_name, contracts::token_wasm(), contracts::token_abi());
+        install_contract(cfg::referral_name, contracts::referral_wasm(), contracts::referral_abi());


Don't change basic tests. Posting smart-contract must work without referral program!

updated #347

…en_the_post_is_published # Conflicts: # golos.referral/abi/golos.referral.abi # golos.referral/include/golos.referral/golos.referral.hpp # golos.referral/src/golos.referral.cpp # tests/golos.referral_tests.cpp

adedkov added this to the Sprint-dec-24 milestone Jan 3, 2019

adedkov self-assigned this Jan 3, 2019

adedkov requested a review from s-medvedev January 3, 2019 14:59

adedkov mentioned this pull request Jan 3, 2019

Add referral to beneficiaries list when the post is published #349

Closed

paying of the referral program #347

0a81a7b

adedkov force-pushed the 349_add_referral_to_beneficiaries_list_when_the_post_is_published branch from ba3b6c9 to babffd2 Compare January 10, 2019 08:25

s-medvedev reviewed Jan 10, 2019

View reviewed changes

s-medvedev reviewed Jan 11, 2019

View reviewed changes

kudzinp and others added 7 commits January 11, 2019 14:33

correction remarks #347

db296a2

updated #347

add referral in list beneficiaries

588e584

add test for referral in benefeciaries list

235b4aa

fix tests

6a18796

update cmakelists

7864510

fix remarks

6510745

fix remarks

ab7b95b

adedkov force-pushed the 349_add_referral_to_beneficiaries_list_when_the_post_is_published branch from 4f30090 to ab7b95b Compare January 11, 2019 12:56

adedkov added 3 commits January 11, 2019 16:19

Merge branch 'develop' into 349_add_referral_to_beneficiaries_list_wh…

73f0746

…en_the_post_is_published # Conflicts: # golos.referral/abi/golos.referral.abi # golos.referral/include/golos.referral/golos.referral.hpp # golos.referral/src/golos.referral.cpp # tests/golos.referral_tests.cpp

fix remark

1a8ddc7

fix bugs

8b217fc

s-medvedev modified the milestones: Sprint-dec-24, Sprint-jan-14 Jan 16, 2019

s-medvedev modified the milestones: Sprint-jan-14, Sprint-jan-28 Jan 28, 2019

s-medvedev closed this Jan 30, 2019

s-medvedev deleted the 349_add_referral_to_beneficiaries_list_when_the_post_is_published branch January 30, 2019 08:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

349 add referral to beneficiaries list when the post is published #389

349 add referral to beneficiaries list when the post is published #389

adedkov commented Jan 3, 2019

s-medvedev Jan 10, 2019

s-medvedev Jan 10, 2019

s-medvedev Jan 11, 2019

s-medvedev Jan 10, 2019

s-medvedev Jan 10, 2019

s-medvedev Jan 11, 2019

s-medvedev Jan 11, 2019

s-medvedev Jan 11, 2019

s-medvedev Jan 11, 2019

349 add referral to beneficiaries list when the post is published #389

349 add referral to beneficiaries list when the post is published #389

Conversation

adedkov commented Jan 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment