Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #4

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Add CI #4

merged 5 commits into from
Jun 23, 2023

Conversation

pinkforest
Copy link

@pinkforest pinkforest commented Jun 23, 2023

Windows side seems to have problems with nanos Precision ...

https://github.com/cyborg-rs/cyborgtime/actions/runs/5357328059/jobs/9718041387?pr=4#step:4:85

.. now is this a standard library feature or some target oddity ?

This "works" but it's "broken":

pub fn format_rfc3339_nanos(system_time: SystemTime) -> Rfc3339Timestamp {
    Rfc3339Timestamp(system_time, Precision::Nanos)
}

       // TODO: precision bug / feature in Windows side !?                                                                                                           
        // https://github.com/cyborg-rs/cyborgtime/actions/runs/5357328059/jobs/9718041387?pr=4#step:4:85                                                             
        #[cfg(not(target_os = "windows"))]
        assert_eq!(
            format_rfc3339_nanos(UNIX_EPOCH +
                Duration::new(1_518_563_312, 789_456_123)).to_string(),
            "2018-02-13T23:08:32.789456123Z");
        #[cfg(target_os = "windows")]
        assert_eq!(
            format_rfc3339_nanos(UNIX_EPOCH +
                Duration::new(1_518_563_312, 789_456_123)).to_string(),
            "2018-02-13T23:08:32.789456100Z");

@pinkforest pinkforest merged commit 8ed9df6 into main Jun 23, 2023
10 checks passed
@guilload guilload deleted the chore-add-ci branch June 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant