Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set labels/annotations of sub-namespaces #7

Closed
4 tasks done
ymmt2005 opened this issue Jul 29, 2021 · 1 comment
Closed
4 tasks done

Set labels/annotations of sub-namespaces #7

ymmt2005 opened this issue Jul 29, 2021 · 1 comment
Assignees

Comments

@ymmt2005
Copy link
Member

ymmt2005 commented Jul 29, 2021

What

Currently, Accurate does not allow tenant users to set new labels/annotations to sub-namespaces created from SubNamespace objects.

It is handy to allow tenant users to set new labels/annotations only when:

  1. the label/annotation key is included in the configuration file, and
  2. the label/annotation is not set for the parent namespace.

How

  1. Add new fields to SubNamespace, for example, spec.labels and spec.annotations
  2. Enhance accurate-controller to create a sub-namespace with the specified labels/annotations.

accurate-controller has to ignore labels/annotations whose key is not listed in the configuration file.

It also should not set labels/annotations if the same labels/annotations are set for the parent namespace.
Nevertheless, the value would be overwritten by the existing Namespace controller to the value of the parent labels/annotations.

Describe how to address the issue.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants