fix: check RBAC to watched resources on startup #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoetrope
reviewed
Jun 10, 2024
I thought about tests when preparing the PR, and I think it's a bit more difficult than usual. But I agree there should ideally be tests for everything and will take another look! |
erikgb
force-pushed
the
validate-rbac
branch
2 times, most recently
from
76d5e49
to
6f6f68c
Compare
|
I have now added some initial tests to this feature. Please let me know if more detailed testing is required. |
zoetrope
approved these changes
Jun 14, 2024
|
@erikgb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more validation of configuration on startup. The operator must have cluster-wide RBAC to CRUD all configured watches to function as intended by the user. At startup, we will now use SelfSubjectAccessReview to check the required RBAC for all configured watches and crash if anything is missing.
Note: After migrating to SSA, we no longer need the
updateverb. I included this minor change in this PR, but please let me know if a dedicated PR is required.Close #102