Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"etcd-added-member" docker volume is left lacking once "etcd-add-member" fails at sync #579

Closed
morimoto-cybozu opened this issue Nov 9, 2022 · 0 comments · Fixed by #600
Closed

"etcd-added-member" docker volume is left lacking once "etcd-add-member" fails at sync #579

morimoto-cybozu opened this issue Nov 9, 2022 · 0 comments · Fixed by #600
Labels
bug Something isn't working

Comments

@morimoto-cybozu
Copy link
Contributor

Describe the bug

waitEtcdSyncCommand in AddMemberOp can fail due to timeout or some other reason.
Once waitEtcdSyncCommand fails, VolumeCreateCommand will be skipped and etcd-added-member docker volume will never be created.

Environments

  • Version: v1.23.4
  • OS: Ubuntu 20.04

To Reproduce

  1. Login to one of the control plane nodes.
  2. Execute docker volume remove etcd-added-member.
  3. Wait and confirm that etcd-added-member is left lacking.

Expected behavior
etcd-added-member is (re-)created after waiting for sync.
@morimoto-cybozu morimoto-cybozu added the bug Something isn't working label Nov 9, 2022
morimoto-cybozu added a commit that referenced this issue Jan 10, 2023
@morimoto-cybozu
Fix added-but-not-marked etcd members
687383f 
Fixes: #579
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
morimoto-cybozu added a commit that referenced this issue Jan 19, 2023
@morimoto-cybozu
Fix added-but-not-marked etcd members
8c6b59f 
Fixes: #579
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
@morimoto-cybozu morimoto-cybozu mentioned this issue Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix added-but-not-marked etcd members cybozu-go/cke
1 participant
@morimoto-cybozu