Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sonobuoy test failing. #589

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fixed sonobuoy test failing. #589

merged 2 commits into from
Dec 6, 2022
+2 −2

Conversation

kmdkuk
Copy link
Contributor

@kmdkuk kmdkuk commented Dec 5, 2022 •
edited
Loading

part of #556, cybozu-go/neco#2114

  • Fix docker-compose download URL
  • Fix confirmation of container exit status
    • before 
      ❯ docker-compose ps setup 
Name          Command         State    Ports
--------------------------------------------
setup   /opt/setup/setup.sh   Exit 0
    • after 
      ❯ docker-compose ps setup
NAME                COMMAND                 SERVICE             STATUS              PORTS
setup               "/opt/setup/setup.sh"   setup               exited (0)
    • Changed to check container exit code from docker inspect instead of the text information in docker-compose ps.

Signed-off-by: kouki kouworld0123@gmail.com

@kmdkuk
fix DOCKER_COMPOSE_URL
d363966 
Signed-off-by: kouki <kouworld0123@gmail.com>
@kmdkuk kmdkuk self-assigned this Dec 5, 2022
@kmdkuk kmdkuk changed the title fix DOCKER_COMPOSE_URL Fixed sonobuoy test failing. Dec 5, 2022
@kmdkuk
Fix confirmation of container exit status
be91421 
Signed-off-by: kouki <kouworld0123@gmail.com>
@kmdkuk
Copy link
Contributor Author

kmdkuk commented Dec 6, 2022

sonobuoy's test results were successful.
https://github.com/cybozu-go/cke/actions/runs/3618074564

zeroalphat
zeroalphat approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmdkuk kmdkuk merged commit 618cde5 into main Dec 6, 2022
@kmdkuk kmdkuk deleted the fix-sonobuoy branch December 6, 2022 06:58
@kmdkuk kmdkuk mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoetrope zoetrope zoetrope approved these changes

@zeroalphat zeroalphat zeroalphat approved these changes

Assignees

@kmdkuk kmdkuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmdkuk @zoetrope @zeroalphat