Fix node filter to check etcd in-sync status properly #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morimoto-cybozu
force-pushed
the
fix-etcd-insyncmembers
branch
from
cfd2165
to
199b79c
Compare
Signed-off-by: morimoto-cybozu <kenji_morimoto@cybozu.co.jp>
morimoto-cybozu
force-pushed
the
fix-etcd-insyncmembers
branch
from
199b79c
to
86e8d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map
cke.EtcdClusterStatus.InSyncMembersis filled byGetEtcdClusterStatus()inop/status.go.It holds not only in-sync members but also not-in-sync members and its length is always equal to the length of
cke.EtcdClusterStatus.Members.This PR fixes a node filter for checking whether all etcd members are in-sync or not.
This PR also fixes the test of the CKE strategy by updating input data closer to the real.
Signed-off-by: morimoto-cybozu kenji_morimoto@cybozu.co.jp