-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of monitor.filter.window: window is not an integer #10
Conversation
cmd/goma/config_test.go
Outdated
|
||
func TestLoadTOML(t *testing.T) { | ||
tmpFileName, err := writeToTempFile(content) | ||
defer os.Remove(tmpFileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err チェックの後にやりましょう。
cmd/goma/config_test.go
Outdated
} | ||
|
||
defer tmpFile.Close() | ||
wtr := bufio.NewWriter(tmpFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bufio いらないでしょう。
_, err = io.WriteString(tmpFile, content)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
指摘箇所の修正をお願いします。
修正しました。確認お願いいたします。 |
@arosh CI 動かしてほしいので、自分のレポジトリではなくこのレポジトリのブランチで作ってください。 |
@arosh ping |
LGTM! |
This PR fixes the following bug.
$ goma register example.toml Server error: 400 Bad Request example: window is not an integer: 2 in filter
The content of
example.toml
is as follows.The TOML specification says that 64 bit range is expected.
See https://github.com/toml-lang/toml#integer