Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default scheme in slack-agent client #125

Merged
merged 1 commit into from Dec 7, 2021
Merged

Add default scheme in slack-agent client #125

merged 1 commit into from Dec 7, 2021

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Dec 6, 2021

Slack notifications fail after updating RunnerPool resources with following error message.

{"level":"error","ts":1638774513.6212428,"logger":"controllers.RunnerManager","msg":"failed to send a notification to slack-agent","runnerpool":"sandbox/readonly-runner","pod":"sandbox/readonly-runner-bdf9f4ffd-wbwk8","error":"Post \"/result\": unsupported protocol scheme \"\"","stacktrace":"github.com/cybozu-go/meows/controllers.(*managerLoop).runOnce\n\tgithub.com/cybozu-go/meows/controllers/runnermanager.go:218\ngithub.com/cybozu-go/meows/controllers.(*managerLoop).start.func1\n\tgithub.com/cybozu-go/meows/controllers/runnermanager.go:181\ngithub.com/cybozu-go/well.(*Environment).Go.func1\n\tgithub.com/cybozu-go/well@v1.10.0/env.go:133"}

Because, when updating a RunnerPool, the HTTP scheme is not set.
https://github.com/cybozu-go/meows/blob/v0.5.0/controllers/runner_manager.go#L163

Signed-off-by: Masayuki Ishii masa213f@gmail.com

Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
Copy link
Contributor

@kmdkuk kmdkuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 12b7b2e into main Dec 7, 2021
@masa213f masa213f deleted the slack-agent-url branch December 7, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants