Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bash completion for necoperf-cli #13

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Add bash completion for necoperf-cli #13

merged 4 commits into from
Oct 25, 2023
+119 −4

Conversation

zeroalphat
Copy link
Contributor

No description provided.

@zeroalphat zeroalphat force-pushed the add-bash-completion branch 2 times, most recently from 38133e2 to 32ab657 Compare October 24, 2023 02:52
@zeroalphat
Add bash completion for necoperf-cli
31f7ea6 
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
umezawatakeshi
umezawatakeshi previously approved these changes Oct 24, 2023
View reviewed changes
Copy link

@umezawatakeshi umezawatakeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question: Why containerCompletionFunc and namespaceCompletionFunc but podCandidates ?

@zeroalphat
Copy link
Contributor Author

This is because podCandidates was originally implemented as a function that only returned a list of pod names.
Should it be renamed from podCandidates to something like podCompletionFunc?

@zeroalphat
Remove debug message
2489fa3 
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
@umezawatakeshi
Copy link

@zeroalphat
I feel it would be nice to change the name to match the actual behavior, a little, but I'll leave it to you.

@zeroalphat
Change function name podCandidates to validArgsCompletionFunc
e1891e6 
Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>
@zeroalphat zeroalphat self-assigned this Oct 25, 2023
morimoto-cybozu
morimoto-cybozu approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroalphat zeroalphat merged commit a9bd043 into main Oct 25, 2023
3 checks passed
@zeroalphat zeroalphat deleted the add-bash-completion branch October 25, 2023 07:07
@zeroalphat zeroalphat added the enhancement New feature or request label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morimoto-cybozu morimoto-cybozu morimoto-cybozu approved these changes

@umezawatakeshi umezawatakeshi Awaiting requested review from umezawatakeshi

Assignees

@zeroalphat zeroalphat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeroalphat @umezawatakeshi @morimoto-cybozu