Add BIOS settings for new equipment #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdkuk
force-pushed
the
add-bios-settings
branch
2 times, most recently
from
858bcb5
to
15bfac1
Compare
kmdkuk
changed the title
kmdkuk
force-pushed
the
add-bios-settings
branch
from
0318da2
to
87084cc
Compare
Signed-off-by: kouki <kouworld0123@gmail.com>
Signed-off-by: kouki <kouworld0123@gmail.com>
Signed-off-by: kouki <kouworld0123@gmail.com>
kmdkuk
force-pushed
the
add-bios-settings
branch
from
87084cc
to
909aad1
Compare
ymmt2005
reviewed
Dec 2, 2021
pkg/setup-hw/dell.go
Outdated
| } | ||
| case lib.R7525: | ||
| // https://www.dell.com/support/manuals/ja-jp/poweredge-r7525/r7525_ism_pub/%E3%83%A1%E3%83%A2%E3%83%AA%E3%83%BC-%E3%83%A2%E3%82%B8%E3%83%A5%E3%83%BC%E3%83%AB%E5%8F%96%E3%82%8A%E4%BB%98%E3%81%91%E3%82%AC%E3%82%A4%E3%83%89%E3%83%A9%E3%82%A4%E3%83%B3?guid=guid-80b1c1ad-14b7-4dd6-b122-abb0c82bd3e8&lang=ja-jp | ||
| return dc.enqueueConfig(ctx, numaSettingsKey, "4") |
There was a problem hiding this comment.
We might change the configurations within a single Dell generation.
Why don't we check # of CPUs & memory units and set the appropriate NUMA setting?
ymmt2005
reviewed
Dec 2, 2021
pkg/setup-hw/dell.go
Outdated
| return err | ||
| } | ||
|
|
||
| numaSettingsKey := "BIOS.ProcSettings.NumaNodesPerSocket" |
There was a problem hiding this comment.
This is used only once. I don't like that the definition and usage are placed so distantly.
Why don't you embed the literal directly at the usage?
ymmt2005
requested changes
Dec 2, 2021
pkg/setup-hw/dell.go
Outdated
Comment on lines
284
to
285
| case lib.R6525: | ||
| case lib.R7525: |
There was a problem hiding this comment.
Suggested change
| case lib.R6525: | |
| case lib.R7525: | |
| case lib.R6525, lib.R7525: |
kmdkuk
force-pushed
the
add-bios-settings
branch
2 times, most recently
from
269fd59
to
e27e0e4
Compare
Signed-off-by: kouki <kouworld0123@gmail.com>
kmdkuk
force-pushed
the
add-bios-settings
branch
from
e27e0e4
to
4931271
Compare
Signed-off-by: kouki <kouworld0123@gmail.com>
Signed-off-by: kouki <kouworld0123@gmail.com>
kmdkuk
force-pushed
the
add-bios-settings
branch
from
4931271
to
1e65e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIOS.ProcSettings.NumaNodesPerSocketsettings for R6525 and R752521.11.26Signed-off-by: kouki kouworld0123@gmail.com