-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #16
Conversation
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the review comment and update the following line to include k8s 1.24.
https://github.com/cybozu-go/tenet/blob/main/.github/workflows/ci.yaml#L61
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the k8s versions of e2e matrix test to ["1.22.15", "1.23.12", "1.24.6"]
.
https://github.com/cybozu-go/tenet/blob/main/.github/workflows/ci.yaml#L61
Signed-off-by: terasihma <tomoya-terashima@cybozu.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I changed bellow.
Signed-off-by: terasihma tomoya-terashima@cybozu.co.jp