fix(batch): make the webpackAwsSdk option available in batchOptions
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 58.01% 58.01%
=======================================
Files 28 28
Lines 3418 3418
Branches 295 295
=======================================
Hits 1983 1983
Misses 1435 1435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faast.js has added support for Node.js 18.x by adding the
webpackAwsSdkoption. If you set it totrue, AWS SDK v2 will be bundled by webpack. However, duck will override this option because/^aws-sdk/?/is included in the externals of webpackOptions by default.This PR fixes that.