feat: enable react/jsx-no-useless-fragment and `@typescript-eslint/…

…no-non-null-assertion` warnings (#541) * Enable @typescript-eslint/no-non-null-assertion * Enable react/jsx-no-useless-fragment * Add tests
cybozu · Jan 19, 2022 · 5dd5077 · 5dd5077
1 parent dffb83d
commit 5dd5077
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 4 deletions.
diff --git a/lib/react.js b/lib/react.js
@@ -100,6 +100,7 @@ module.exports = {
       },
     ],
     "react/jsx-wrap-multilines": "warn",
+    "react/jsx-no-useless-fragment": "warn",
 
     // =======
     // None

diff --git a/lib/typescript.js b/lib/typescript.js
@@ -22,8 +22,6 @@ module.exports = {
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/no-inferrable-types": "off",
-    // FIXME use NonNullable<T> instead
-    "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/no-object-literal-type-assertion": "off",
     "@typescript-eslint/no-triple-slash-reference": "off",
     "@typescript-eslint/no-unused-vars": "off",

diff --git a/test/fixtures/react/warning.jsx b/test/fixtures/react/warning.jsx
@@ -0,0 +1,2 @@
+const foo = 3;
+<>{foo}</>;
diff --git a/test/presets-test.js b/test/presets-test.js
@@ -16,6 +16,9 @@ describe("presets", () => {
         await runLintWithFixtures("react", "presets/react.js"),
         {
           "ok.jsx": {},
+          "warning.jsx": {
+            warnings: ["react/jsx-no-useless-fragment", "react/jsx-indent"],
+          },
         }
       );
       assert.deepStrictEqual(

diff --git a/test/react-test.js b/test/react-test.js
@@ -7,6 +7,9 @@ describe("react", () => {
     const result = await runLintWithFixtures("react", "presets/react.js");
     assert.deepStrictEqual(result, {
       "ok.jsx": {},
+      "warning.jsx": {
+        warnings: ["react/jsx-no-useless-fragment", "react/jsx-indent"],
+      },
     });
   });
 });
diff --git a/test/react-typescript-test.js b/test/react-typescript-test.js
@@ -14,7 +14,10 @@ describe("react-typescript", () => {
         errors: ["@typescript-eslint/array-type"],
       },
       "warning.tsx": {
-        warnings: ["@typescript-eslint/no-useless-constructor"],
+        warnings: [
+          "@typescript-eslint/no-useless-constructor",
+          "@typescript-eslint/no-non-null-assertion",
+        ],
       },
     });
   });

diff --git a/test/typescript-test.js b/test/typescript-test.js
@@ -11,7 +11,10 @@ describe("typescript", () => {
         errors: ["@typescript-eslint/array-type"],
       },
       "warning.ts": {
-        warnings: ["@typescript-eslint/no-useless-constructor"],
+        warnings: [
+          "@typescript-eslint/no-useless-constructor",
+          "@typescript-eslint/no-non-null-assertion",
+        ],
       },
     });
   });