Resource Mass Sometimes Misreported

[toadicus]

In some situations, the resourceMass and totalResourceMass values I'm fetching from KER do not seem to make sense. Using the Kerbal X as an example; here's a readout of the stages in the editor:

"Mass" and "Total Mass" are fetched directly from Stage.mass and Stage.totalMass. Here's my vessel info panel on the pad before staging at all:

The slight difference in total mass is the fault of another mod of mine, but is consistent. However, the reported Resource Mass of 145 tons is necessarily incorrect. "Resource Mass (stage)" is Stage.resourceMass and "Resource Mass" is Stage.totalResourceMass.

Here's the panel again after releasing the launch clamps (so we've staged twice):

The fuel mass in two nacelles is 400 * 3 * 2 * .005 = 12 kg. In all 6 nacelles it's 36 kg. There's another 48 kg in the center stack. None of those values or any reasonable sum seem to be represented here. Also, the 25.806 value does not change as fuel burns.

When the first pair of nacelles runs out of fuel, but before they're decoupled, the readouts change:

Again, both resource values reported much be incorrect, as they are equal to or greater than the total craft mass.

When the first pair of nacelles are decoupled (so we've staged one more time), it changes again:

As a temporary workaround, I have hacked access to baseMass at the stage level into my local fork.

Let me know how I can help!

[Gerry1135]

I believe the fix for this is to change this line in simulation.cs:

stage.resourceMass = this.stepStartMass - this.stepEndMass;

to:

stage.resourceMass = this.stageStartMass - this.stepEndMass;

Toadicus is going to try this and let us know.

[toadicus]

That does appear to fix it. Thanks!