-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
margin/align name inconsistency #145
Comments
Good point. What do you suggest? |
I have mixed feelings about supporting both. |
OK, but how about vtile, htile, etc.? Also, in english, you call it "right margin" (a noun) No one calls it "margin right", unless it is a phrase: "margin at the right". So is align-left, "align" is not a noun, it is a verb. So that's the difference. |
It would probably be cool to have this syntax: |
Yes, that can be done, I think. |
I think I like this syntax a lot. It also solves my problem of combination. For example, I've also been mulling about the alternative syntax for proxies. Examples: box | align.top.left | margin(10, 10, 20, 20) ... compared to the current syntax: align_top_left(margin(10, 10, 20, 20), box) |
I really like |
Now that more users are already using elements, if we do this, it is time to use the [[deprecated]] feature. It is also probably time to have a stabilized version, on the way to v1.0 (perhaps v0.8). My idea is to move deprecated APIs in a separate directory, to keep the main API clean. Any API that is bound to change, that is already in the examples or already documented, should have a deprecation notice. |
New thing: docs mention: // variant 1
vmargin({ top, bottom }, subject)
// variant 2
vmargin(top, bottom, subject)
// variant 3
top_bottom_margin({ top, bottom }, subject)
// variant 4
top_bottom_margin(top, bottom, subject) But actually none of these functions exist. There are |
Good catch! I'll look into it ASAP. |
fixed in e2c2d22 |
I just realized there is
align_left
,align_right
etc but alsoleft_margin
,right_margin
. Is this intended? IMO it would be good to have everything spelled one way.The text was updated successfully, but these errors were encountered: