Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to add Foreign Key via attribute #91

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Nov 2, 2023

@msmakouz msmakouz added the type:feature New feature. label Nov 2, 2023
@msmakouz msmakouz added this to the 3.2.x milestone Nov 2, 2023
@msmakouz msmakouz self-assigned this Nov 2, 2023
@msmakouz msmakouz modified the milestones: 3.2.x, 3.4.x Nov 2, 2023
@msmakouz msmakouz linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (42ab4a2) 91.35% compared to head (b4fa5c0) 91.36%.

Files Patch % Lines
src/Configurator.php 78.12% 7 Missing ⚠️
src/Entities.php 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                3.x      #91   +/-   ##
=========================================
  Coverage     91.35%   91.36%           
- Complexity      269      285   +16     
=========================================
  Files            32       33    +1     
  Lines           694      741   +47     
=========================================
+ Hits            634      677   +43     
- Misses           60       64    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit bb376d2 into 3.x Nov 23, 2023
9 of 10 checks passed
@roxblnfk roxblnfk deleted the feature/fk branch November 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Attribute #[ForeignKey]
3 participants