Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inserting order in regular cases #381

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Conversation

gam6itko
Copy link
Contributor

@gam6itko gam6itko commented Nov 25, 2022

Close #380

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (31e29e4) 91.51% compared to head (a6662af) 91.49%.

❗ Current head a6662af differs from pull request most recent head 23db770. Consider uploading reports for the commit 23db770 to get more accurate results

Files Patch % Lines
src/Transaction/Pool.php 91.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #381      +/-   ##
============================================
- Coverage     91.51%   91.49%   -0.02%     
- Complexity     1804     1811       +7     
============================================
  Files           114      115       +1     
  Lines          4582     4587       +5     
============================================
+ Hits           4193     4197       +4     
- Misses          389      390       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk changed the title [tests] broken insert order Fix inserting order in regular cases Feb 13, 2024
@roxblnfk roxblnfk merged commit 5c8c208 into cycle:2.x Feb 13, 2024
32 of 35 checks passed
@gam6itko gam6itko deleted the broken_insert_order branch February 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Several entities broken insert order
2 participants