Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass arguments directly to the database join methods #447

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Pass arguments directly to the database join methods #447

merged 4 commits into from
Dec 8, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 7, 2023 •
edited

Closes: #398

@msmakouz msmakouz self-assigned this Dec 7, 2023
@msmakouz msmakouz marked this pull request as draft December 7, 2023 12:42
@msmakouz msmakouz linked an issue Dec 7, 2023 that may be closed by this pull request
Cycle\Orm\Select adds a master table prefix before the name of the table to be joined in MtM case #398
Closed
@msmakouz msmakouz changed the title Adding test case for issue #398 Pass arguments directly to the database join methods Dec 7, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8500a5) 91.62% compared to head (0c35fad) 91.63%.
Report is 4 commits behind head on 2.x.

❗ Current head 0c35fad differs from pull request most recent head a6da9b1. Consider uploading reports for the commit a6da9b1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x     #447   +/-   ##
=========================================
  Coverage     91.62%   91.63%           
- Complexity     1773     1775    +2     
=========================================
  Files           113      113           
  Lines          4516     4520    +4     
=========================================
+ Hits           4138     4142    +4     
  Misses          378      378

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz marked this pull request as ready for review December 7, 2023 13:38
@msmakouz msmakouz removed the type:test Test label Dec 7, 2023
@roxblnfk roxblnfk merged commit 5d19075 into 2.x Dec 8, 2023
29 of 30 checks passed
@roxblnfk roxblnfk deleted the bugfix/issue-398 branch December 8, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees

@msmakouz msmakouz

Labels
type:bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cycle\Orm\Select adds a master table prefix before the name of the table to be joined in MtM case
2 participants
@msmakouz @roxblnfk