Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding loophp/collection v7 support #448

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 7, 2023

What was changed

Added support for loophp/collection version 7.0

Closes: #387

@msmakouz msmakouz added the type:feature New feature. label Dec 7, 2023
@msmakouz msmakouz self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c8500a5) 91.62% compared to head (4c162c5) 91.42%.

Files Patch % Lines
src/Collection/Pivoted/LoophpPivotedCollection.php 36.84% 12 Missing ⚠️
src/Collection/LoophpCollectionFactory.php 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #448      +/-   ##
============================================
- Coverage     91.62%   91.42%   -0.21%     
- Complexity     1773     1792      +19     
============================================
  Files           113      114       +1     
  Lines          4516     4547      +31     
============================================
+ Hits           4138     4157      +19     
- Misses          378      390      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add support for PivotedCollection here for the MtM relation?

@msmakouz
Copy link
Member Author

msmakouz commented Dec 8, 2023

Could you add support for PivotedCollection here for the MtM relation?

Added.

@roxblnfk roxblnfk merged commit 655975e into 2.x Dec 8, 2023
30 of 32 checks passed
@roxblnfk roxblnfk deleted the feature/loophp-collection-v7 branch December 8, 2023 12:16
@roxblnfk roxblnfk modified the milestone: 2.6.x Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔍 Check compatibility with loophp/collection v7
3 participants