Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded entity's fields conflict with the parent ones even using columnPrefix #24

Merged
merged 4 commits into from
Mar 25, 2021

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Mar 23, 2021

Fix #23
Todo:

  • Add test case
  • Resolve proplem

@roxblnfk roxblnfk marked this pull request as ready for review March 24, 2021 13:27
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #24 (22dfcdc) into master (005c71b) will increase coverage by 2.25%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     89.11%   91.36%   +2.25%     
- Complexity      398      426      +28     
============================================
  Files            31       33       +2     
  Lines          1001     1065      +64     
============================================
+ Hits            892      973      +81     
+ Misses          109       92      -17     
Impacted Files Coverage Δ Complexity Δ
...ion/FieldException/EmbeddedPrimaryKeyException.php 33.33% <33.33%> (ø) 4.00 <4.00> (?)
src/Definition/Map/FieldMap.php 100.00% <100.00%> (+14.28%) 10.00 <0.00> (ø)
src/Relation/Embedded.php 100.00% <100.00%> (+100.00%) 5.00 <0.00> (+1.00)
src/Compiler.php 86.41% <0.00%> (-6.12%) 31.00% <0.00%> (+5.00%) ⬇️
src/Definition/Comparator/FieldComparator.php 100.00% <0.00%> (ø) 18.00% <0.00%> (?%)
src/Registry.php 90.21% <0.00%> (+2.17%) 42.00% <0.00%> (ø%)
src/Generator/RenderTables.php 84.61% <0.00%> (+3.84%) 12.00% <0.00%> (ø%)
src/Definition/Field.php 100.00% <0.00%> (+5.40%) 17.00% <0.00%> (ø%)
src/Definition/Entity.php 96.66% <0.00%> (+6.66%) 37.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005c71b...22dfcdc. Read the comment docs.

@wolfy-j wolfy-j merged commit ed8df4d into cycle:master Mar 25, 2021
@roxblnfk roxblnfk deleted the hotfix/23 branch March 25, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded entity's fields conflict with the parent ones (even using columnPrefix)
2 participants