Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate versions of xstream #117

Closed
geovanisouza92 opened this issue Oct 4, 2017 · 2 comments
Closed

Duplicate versions of xstream #117

geovanisouza92 opened this issue Oct 4, 2017 · 2 comments

Comments

@geovanisouza92
Copy link
Member

geovanisouza92 commented Oct 4, 2017

Code to reproduce the issue:

create-cycle-app example --flavor cycle-scripts-one-fits-all
cd example
npm run eject
npm install --save-dev webpack-bundle-analyzer

Change webpack.config.js as the following;

const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;

module.exports = {
    // ...
    plugins: [new BundleAnalyzerPlugin()]
};
npm run build

Expected behavior:

Include xstream on the bundle only once (the blue rect)

Actual behavior:

Included four times on the bundle

selecao_007

Versions of packages used:

  • create-cycle-app@3.0.8
  • cycle-scripts-one-fits-all@4.2.2
yarn list v0.27.5
├─ @cycle/dom@18.3.0
├─ @cycle/http@14.4.0
├─ @cycle/isolate@3.1.0
├─ @cycle/run@3.3.0
├─ @cycle/time@0.8.0
├─ cycle-onionify@3.3.0
├─ cycle-restart@0.2.2
├─ xstream@10.9.0

This is related to @cycle/run, @cycle/time and cycle-onionify, spotted on cyclejs/cyclejs#700

@jvanbruegge
Copy link
Collaborator

Will investigate tomorrow
Together with this uglify bug

@jvanbruegge
Copy link
Collaborator

Not the case any more in one-fits-all V5

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants