Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack build fails with Typescript 2.1 #49

Closed
wmaurer opened this issue Dec 10, 2016 · 4 comments
Closed

Webpack build fails with Typescript 2.1 #49

wmaurer opened this issue Dec 10, 2016 · 4 comments
Assignees
Labels

Comments

@wmaurer
Copy link

wmaurer commented Dec 10, 2016

Code to reproduce the issue:
$ create-cycle-app my-app with TypeScript + Webpack
$ npm i typescript --save-dev (installs typescript 2.1)
$ npm start

Expected behavior:
No errors ;-)

Actual behavior:
Error message with partial trace:

PS D:\Projects\my-app> npm start

> my-app@0.1.0 start D:\Projects\my-app
> cycle-scripts start

  build [========            ] 40%TypeError: Cannot read property 'exclude' of undefined
    at applyDefaults (D:\Projects\my-app\node_modules\awesome-typescript-loader\src\instance.ts:266:72)

Versions of packages used:
create-cycle-app 1.0.0
typescript 2.1

I can confirm that this does not occur with typescript 2.0.10.

@wmaurer
Copy link
Author

wmaurer commented Dec 10, 2016

Ok, I've found a solution to this problem in case anybody else comes across it. awesome-typescript-loader needs to be upgraded to a version that supports typescript 2.1.

At the time of writing, the latest version is awesome-typescript-loader@3.0.0-beta.10

ref: s-panferov/awesome-typescript-loader#190
ref: s-panferov/awesome-typescript-loader#293

@geovanisouza92
Copy link
Member

@nickbalestra can you take a look at this and update that dependency? :)

@nickbalestra
Copy link
Collaborator

Thanks @wmaurer for reporting this!
@geovanisouza92 sure! Just an idea: but maybe is worth considering to add greenkeeper?

@nickbalestra nickbalestra self-assigned this Dec 12, 2016
@geovanisouza92
Copy link
Member

geovanisouza92 commented Dec 12, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants