Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing credits on license #48

Closed
wants to merge 1 commit into from
Closed

Changing credits on license #48

wants to merge 1 commit into from

Conversation

geovanisouza92
Copy link
Member

  • I ran npm test for the package I'm modifying
  • I used npm run commit instead of git commit
  • I have rebased my branch onto master before merging

@Widdershin
Copy link
Member

Hmmm, can a community copyright some code? I love the idea, just worried that it might make the license invalid.

@geovanisouza92
Copy link
Member Author

@Widdershin To me, it seems to selfish take all the credits, when clearly there are more people contributing, at least with a issue or question.

I'm not sure about the validity of the license for a community. Do you have another idea?

@nickbalestra
Copy link
Collaborator

@geovanisouza92 @Widdershin what do we want to do with this?

I personally think we could add a contributors.md instead as I've seen elsewhere (i.e on standard where they even have a nice script to auto generate it that we could perhaps borrow - https://github.com/feross/standard/blob/master/bin/update-authors.sh).
This will leave the licence as it is so that we are sure it's valid. If you ok with this I'll go ahead close this PR and open an issue to move ahead with the contributors.md idea.

@Widdershin
Copy link
Member

Widdershin commented Jan 30, 2017 via email

@nickbalestra nickbalestra mentioned this pull request Jan 30, 2017
perjerz pushed a commit to perjerz/create-cycle-app that referenced this pull request Nov 12, 2018
add cycle-electron-driver (able to merge)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants