remove default value on empty storage item #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes that's what I have imagined. |
| .filter((req) => req.key === key) | ||
| .map((req) => req.value) | ||
| .startWith(initialValue) | ||
|
|
||
| if (initialValue) { |
There was a problem hiding this comment.
Maybe we should check for initialValue!==null explicitly so allow falsy values like "" to be stored.
|
added the type check |
|
Thank you |
|
no problem, will merge after the tests pass should this be a major version bump or just minor? |
|
I think it should be a major again since somebody could rely on the empty item being emitted. |
|
yeah, I am thinking the same thing |
kahlil
added a commit
that referenced
this pull request
Nov 25, 2015
remove default value on empty storage item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@laszlokorte this PR should do the trick, wanna review?