Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http test script do not run http test-node, only test-browser #865

Closed
Sinewyk opened this issue Dec 10, 2018 · 1 comment · Fixed by #866
Closed

http test script do not run http test-node, only test-browser #865

Sinewyk opened this issue Dec 10, 2018 · 1 comment · Fixed by #866
Labels
issue is bug priority 3 (should) scope: http size S

Comments

@Sinewyk
Copy link
Contributor

Sinewyk commented Dec 10, 2018

Since fe3c5ce

They seem to be broken on master because they are not automatically ran anymore.

How it should be: https://github.com/cyclejs/cyclejs/blob/master/dom/package.json#L45
How it is: https://github.com/cyclejs/cyclejs/blob/master/http/package.json#L69

suggested labels: issue is bug, help wanted, priority 3 (should), scope: http
@Sinewyk Sinewyk mentioned this issue Dec 10, 2018
Open
jvanbruegge added a commit that referenced this issue Dec 10, 2018
@jvanbruegge
chore(http): run http node tests in CI again
d1f8084 
ISSUES CLOSED: #865
@jvanbruegge jvanbruegge mentioned this issue Dec 10, 2018
Merged
3 tasks
@jvanbruegge
Copy link
Member

@Sinewyk thanks for noticing, I've opened a PR to fix this

jvanbruegge added a commit that referenced this issue Dec 10, 2018
@jvanbruegge
chore(http): run http node tests in CI again
cfd046f 
ISSUES CLOSED: #865
musicq pushed a commit to musicq/cyclejs that referenced this issue Feb 15, 2020
@jvanbruegge @musicq
chore(http): run http node tests in CI again
798bd2e 
ISSUES CLOSED: cyclejs#865
fuunnx pushed a commit to fuunnx/cyclejs that referenced this issue Feb 24, 2021
@jvanbruegge
chore(http): run http node tests in CI again
0ba0eec 
ISSUES CLOSED: cyclejs#865
fuunnx pushed a commit to fuunnx/cyclejs that referenced this issue Feb 24, 2021
@jvanbruegge
chore(http): run http node tests in CI again
94c8d9b 
ISSUES CLOSED: cyclejs#865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue is bug priority 3 (should) scope: http size S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(http): run http node tests in CI again cyclejs/cyclejs
2 participants
@jvanbruegge @Sinewyk