Update with a working example #23
Conversation
| ); | ||
|
|
||
| return { | ||
| react: elem$, | ||
| }; | ||
| } | ||
|
|
||
| run(main, { |
There was a problem hiding this comment.
Did run not work? It should work.
There was a problem hiding this comment.
Nope, was left out at a blank render unless a delay was added
There was a problem hiding this comment.
Then that's a bug, run needs to work (I'm sure it once worked).
There was a problem hiding this comment.
Then that's a bug, run needs to work (I'm sure it once worked).
There was a problem hiding this comment.
In that case the PR can be ignored, I'll try to look into the run issue
| buttonText: { | ||
| color: 'white', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
For the purposes of a readme example, we don't need styles.
There was a problem hiding this comment.
I’d recommend keeping the view container style , since on modern devices the counter touchable goes behind the statusbar / notch / etc.
i’ll remove the other styles
| TouchableHighlight, | ||
| Text, | ||
| } from '@cycle/react-native'; | ||
| import {name as appName} from './app.json'; |
There was a problem hiding this comment.
We don't need this in a readme example, can you revert this?
There was a problem hiding this comment.
the name import? yeah will do
|
No,
it just halts at a white screen, had to add a delay
…On 1 Aug 2022, 1:14 PM +0530, André Staltz ***@***.***>, wrote:
@staltz commented on this pull request.
In readme.md:
> );
return {
react: elem$,
};
}
-run(main, {
Did run not work? It should work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Replaces the older example with a current working example for the following versions