Skip to content

Commit

Permalink
Revert "Add successThreshold, close #86"
Browse files Browse the repository at this point in the history
  • Loading branch information
Robinlovelace committed Nov 14, 2023
1 parent a424cf2 commit 46e451d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 21 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: cyclestreets
Title: Cycle Routing and Data for Cycling Advocacy
Version: 1.1.0
Version: 1.0.1
Authors@R: c(
person("Robin", "Lovelace", , "rob00x@gmail.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-5679-6536")),
Expand Down
4 changes: 0 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# cyclestreets 1.1.0 (November 2023)

* New argument `successThreshold` (#86)

# cyclestreets 1.0.1

* Bug fix: issue with batch identified and fix (#80) thanks to @mem48
Expand Down
10 changes: 2 additions & 8 deletions R/batch.R
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
#' pause: Pause job
#' continue: Continue (re-open) job
#' terminate: Terminate job and delete data
#' @param successThreshold int (0-100) The percentage of routes that must be successfully
#' calculated before the job is considered complete.
#' @param delete_job Delete the job? TRUE by default to avoid clogged servers
#' @param cols_to_keep Columns to return in output sf object
#' @param segments logical, return segments TRUE/FALSE/"both"
Expand Down Expand Up @@ -96,7 +94,6 @@ batch = function(
emailOnCompletion = "you@example.com",
username = Sys.getenv("CYCLESTREETS_UN"),
password = Sys.getenv("CYCLESTREETS_PW"),
successThreshold = 90,
base_url = "https://api.cyclestreets.net/v2/batchroutes.createjob",
pat = Sys.getenv("CYCLESTREETS_BATCH"),
silent = TRUE,
Expand Down Expand Up @@ -134,7 +131,6 @@ batch = function(
password,
base_url,
id,
successThreshold,
pat,
silent = silent
)
Expand Down Expand Up @@ -281,8 +277,7 @@ batch_routes = function(
base_url = "https://api.cyclestreets.net/v2/batchroutes.createjob",
id = 1,
pat,
silent = TRUE,
successThreshold
silent = TRUE
) {
batch_url = paste0(base_url, "?key=", pat)
desire_lines_to_send = desire_lines["id"]
Expand All @@ -303,8 +298,7 @@ batch_routes = function(
includeJsonOutput = includeJsonOutput,
emailOnCompletion = emailOnCompletion,
username = username,
password = password,
successThreshold
password = password
)
message("POSTing the request to create and start the job")
if(!silent) {
Expand Down
9 changes: 1 addition & 8 deletions man/batch.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 46e451d

Please sign in to comment.