generate: Add support for multiple modules having same resource names #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xescugc
added
the
need review
|
Rebased and ready to be reviewed |
tormath1
reviewed
Mar 9, 2021
CHANGELOG.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| ## [Unreleased] | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Multiple modules with same resource name now work correctly using full module name `module.NAME.aws_insatance.NAME2` | |||
There was a problem hiding this comment.
Suggested change
| - Multiple modules with same resource name now work correctly using full module name `module.NAME.aws_insatance.NAME2` | |
| - Multiple modules with same resource name now work correctly using full module name `module.NAME.aws_instance.NAME2` |
|
Done :) |
|
@xescugc you can RS then |
What we'll do is check if there are more than 1 module with resources, if so then we'll use full resource name 'module.NAME.aws_instance.NAME2' as canonical. This will also be used on the config output as key canonical for the resource. If there is only 1 module they'll not be prefixed in favor of readability of the names.
|
Done |
tormath1
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we'll do is check if there are more than 1 module with resources, if so then we'll use full
resource name 'module.NAME.aws_instance.NAME2' as canonical. This will also be used on the config
output as key canonical for the resource.
If there is only 1 module they'll not be prefixed in favor of readability of the names.
Closes #103