-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we change the makefile to be more Goish? #34
Comments
I would say yes because for example, having by default the test be with the The other outputs that say That's the way I see it, and basically the go tools follow this approch of only printing what it has value to be read. |
I'm the one that think that the most of the times log files should only contains actionable information, so it makes clear my preference. |
I'm fine with both, I'd rather use While for the message, we could indeed reduce the output. I still like a summary of 'ok/ko' for simple test, and 'ok/all-error-messages' for more complex ones (so basically what go does) |
That's fine However the question is more about if we suppress the ok messages? |
Also removed some verbosity on the tests #34
Also removed some verbosity on the tests #34
Also removed some verbosity on the tests #34
Also removed some verbosity on the tests #34
As commented in #31 (comment) the Makefile targets doesn't follow the convention which has been taken by the most of the Go tools, which is to be silent if everything is OK or in case of having a verbose option if it isn't enabled.
The
Makefiles
, requires some minor homogenizations (useprintf
rather thanecho
command as @xlr-8 has mentioned), however if the goal is to change to be more Goish, then there is no need to have such minor changes as we could change it entirely.I cannot say why the
Makefile
is this way, so I'm not writing here any reason or favor on the current way, because, basically, I don't know.The question is, should we change it to be more Goish?
The text was updated successfully, but these errors were encountered: