Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we change the makefile to be more Goish? #34

Closed
ifraixedes opened this issue Mar 12, 2018 · 4 comments · Fixed by #49
Closed

Should we change the makefile to be more Goish? #34

ifraixedes opened this issue Mar 12, 2018 · 4 comments · Fixed by #49
Assignees

Comments

@ifraixedes
Copy link
Contributor

ifraixedes commented Mar 12, 2018

As commented in #31 (comment) the Makefile targets doesn't follow the convention which has been taken by the most of the Go tools, which is to be silent if everything is OK or in case of having a verbose option if it isn't enabled.

The Makefiles, requires some minor homogenizations (use printf rather than echo command as @xlr-8 has mentioned), however if the goal is to change to be more Goish, then there is no need to have such minor changes as we could change it entirely.

I cannot say why the Makefile is this way, so I'm not writing here any reason or favor on the current way, because, basically, I don't know.

The question is, should we change it to be more Goish?

@xescugc
Copy link
Member

xescugc commented Mar 12, 2018

I would say yes because for example, having by default the test be with the -v is a bad idea, once you have more that 50 test the output is totally unreadable.

The other outputs that say ok [...] makes the User read those outpus because maybe they are importan, when they are just saying that everithing was ok, so nothing to read there.

That's the way I see it, and basically the go tools follow this approch of only printing what it has value to be read.

@ifraixedes
Copy link
Contributor Author

ifraixedes commented Mar 13, 2018

I'm the one that think that the most of the times log files should only contains actionable information, so it makes clear my preference.

@xlr-8
Copy link
Contributor

xlr-8 commented Mar 13, 2018

I'm fine with both, I'd rather use printf as it seems more adapted for every platform.

While for the message, we could indeed reduce the output. I still like a summary of 'ok/ko' for simple test, and 'ok/all-error-messages' for more complex ones (so basically what go does)

@ifraixedes
Copy link
Contributor Author

I'm fine with both, I'd rather use printf as it seems more adapted for every platform.

That's fine

However the question is more about if we suppress the ok messages?

xescugc added a commit that referenced this issue Jun 11, 2019
Also removed some verbosity on the tests #34
xescugc added a commit that referenced this issue Jun 11, 2019
Also removed some verbosity on the tests #34
xescugc added a commit that referenced this issue Jun 11, 2019
Also removed some verbosity on the tests #34
xescugc added a commit that referenced this issue Jun 12, 2019
Also removed some verbosity on the tests #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants